comment on

I've solved that problem thatks to your help but as I was expanding the script perl threw up these crazy errors:

syntax error at albums.cgi line 102, near "else"
syntax error at albums.cgi line 110, near "elsif"
albums.cgi had compilation errors (#1)
    (F) The final summary message when a perl -c fails.

Uncaught exception from user code:
        syntax error at albums.cgi line 102, near "else"
syntax error at albums.cgi line 110, near "elsif"
albums.cgi had compilation errors.

Now I've gone to the lines in question and searched the surrounding lines but cannot find a problem.

Heres the modified code

#!/usr/bin/perl -w

use strict;
use warnings;
use diagnostics;

use CGI;

my $q = new CGI;

my $status   =  $q->param('status');
my $album    =  $q->param('album') ;
my $page     =  $q->param('page')  ;
my $img      =  $q->param('pic')   ;
my $user     =  $q->param('user')  ;
my @html;
my $row;
my $src;
my $pic;
my $html;
my $viewersrc = "http://eoinmurphy00.netfirms.com/albums/$album/$img";
my $nextpage_html = qq();


if ($status eq "viewall"){
$html = viewall($page);      
}

elsif ($status eq "viewer"){
$html = viewer($viewersrc, $user);
}

print qq(Content-type: text/html\n
$html);




sub viewall{
   
   my $pic;
   my $dir = "../www/albums/$album";
   my( $page )= @_;
   if ($page == undef)
   {$page=0;}
   else
   {}
   
   opendir DIR, "$dir" or die $!;
   my @images= grep /\.jpg/, readdir DIR;
   closedir DIR;


   if ($page == 0){
   my $nextpage = "1";
   my $ttlcounter = "0";
   my $tmpcounter = "0"; 
   foreach $pic (@images)
   {
    $src = "http://eoinmurphy00.netfirms.com/albums/$album/$pic";
    if ($ttlcounter <= 24)
    {
    if ($tmpcounter eq 3)
     {
     $tmpcounter = "0";
           $row = qq(</tr>
               <tr>
                      <td>&nbsp;</td>
                      <td>&nbsp;</td>
                      <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   </tr>
                   <tr>
                   <td>\&nbsp;</td>
               <td><a href="http://eoinmurphy00.netfirms.com/cgi-bin/a
+lbums.cgi?status=viewer&album=$album&pic=$pic&user=$user"><img src="$
+src" width="175" height="129"></a></td>
                   <td>\&nbsp;</td>
                   <td>\&nbsp;</td>);

     push @html, $row;
     $tmpcounter++;
     $ttlcounter++;
     }

     else
     {       
     $row = qq(<td>\&nbsp;</td>
               <td><a href="http://eoinmurphy00.netfirms.com/cgi-bin/a
+lbums.cgi?status=viewer&album=$album&pic=$pic&user=$user"><img src="$
+src" width="175" height="129"></a></td>
                   <td>\&nbsp;</td>
                   <td>\&nbsp;</td>);      

     push @html, $row;
     $tmpcounter++;
     $ttlcounter++;
     }
   }
   }
   else
   {
   $nextpage_html = qq(<a href="http://eoinmurphy00.netfirms.com/cgi-b
+in/albums.cgi?status=viewall&album=$album&page=$nextpage&user=$user">
+Next page</a>);
}
}



elsif($page eq 1){
   my $nextpage = "2";
   my $ttlcounter = "0";
   my $tmpcounter = "0"; 
   my $counter = "0";
   my $img;
   my @images;
   for ($counter = 25, $counter =< 48, $counter++)
   {
   $img = "img$counter.jpg";
   @images = push($img);
   }
   foreach $pic (@images)
   {
    $src = "http://eoinmurphy00.netfirms.com/albums/$album/$pic";
    if ($ttlcounter =< 24)
    {
    if ($tmpcounter == 3)
     {
     $tmpcounter = "0";
           $row = qq(</tr>
               <tr>
                      <td>&nbsp;</td>
                      <td>&nbsp;</td>
                      <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   <td>&nbsp;</td>
                   </tr>
                   <tr>
                   <td>\&nbsp;</td>
               <td><a href="http://eoinmurphy00.netfirms.com/cgi-bin/a
+lbums.cgi?status=viewer&album=$album&pic=$pic&user=$user"><img src="$
+src" width="175" height="129"></a></td>
                   <td>\&nbsp;</td>
                   <td>\&nbsp;</td>);

     push @html, $row;
     $tmpcounter++;
     $ttlcounter++;
     }

     else
     {       
     $row = qq(<td>\&nbsp;</td>
               <td><a href="http://eoinmurphy00.netfirms.com/cgi-bin/a
+lbums.cgi?status=viewer&album=$album&pic=$pic&user=$user"><img src="$
+src" width="175" height="129"></a></td>
                   <td>\&nbsp;</td>
                   <td>\&nbsp;</td>);      

     push @html, $row;
     $tmpcounter++;
     $ttlcounter++;
     }
   }
   }
   else
   {
   $nextpage_html = qq(<a href="http://eoinmurphy00.netfirms.com/cgi-b
+in/albums.cgi?status=viewall&album=$album&page=$nextpage&user=$user">
+Next page</a>);
}








my $album_html = qq(

<html>

<head>
<meta http-equiv="Content-Type"
content="text/html; charset=iso-8859-1">
<meta name="GENERATOR" content="Microsoft FrontPage Express 2.0">
<title>Apres Bonne Anse Plage</title>
</head>

<body bgcolor="#000098" link="#FFFFFF" vlink="#FFFFFF"
alink="#FFFFFF">

<p align="center">&nbsp;</p>
<div align="center"><center>

<table border="0" cellpadding="0" cellspacing="0">
    <tr>
        <td colspan="5"><img src="http://eoinmurphy00.netfirms.com/ima
+ges/title.jpg"
        width="780" height="224"><br>
        </td>
    </tr>
    <tr>
        <td colspan="5"><div align="center"><center><table
        border="1" cellpadding="0" cellspacing="0" width="780">
            <tr>
                <td align="center" bordercolor="#FFFFFF"><p
                align="center"><font color="#FFFFFF" size="6"
                face="ITC Zapf Chancery"><strong><u>$album</u></strong
+></font></p>
                <hr>
                <div align="center"><center><table border="0"
                cellpadding="0" cellspacing="0">
                    <tr>
                        @html
                </table>
                </center></div><p align="right"><font
                color="#FFFFFF" face="Abbess"><em>$nextpage_html;</em>
+</font>&nbsp;</p>
                <div align="center"><center><table border="1"
                cellpadding="0" cellspacing="0" width="775">
                    <tr>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=home&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Home</u></
+strong></font></a></p>
                        </td>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=albums&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Albums</u>
+</strong></font></a></p>
                        </td>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=upload&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Upload</u>
+</strong></font></a></p>
                        </td>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=contact&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Contact
                        </u></strong></font></a></p>
                        </td>
                    </tr>
                </table>
                </center></div></td>
            </tr>
        </table>
        </center></div><p><font color="#FFFFFF" face="Abbess"><img
        src="http://eoinmurphy00.netfirms.com/images/border.jpg" width
+="780" height="51"></font></p>
        </td>
    </tr>
</table>
</center></div>
</body>
</html>);

return $album_html
}

sub viewer{

my( $src, $user ) = @_;
my @splitsrc = split(/\//, $src);
my $currentpic = pop(@splitsrc);
my @imgnmbr = ($currentpic =~ /\d+/g);
my $nextimgnmbr = $imgnmbr[0];
my $previmgnmbr = $imgnmbr[0];
$nextimgnmbr++;
$previmgnmbr--;
my $nextpic = "pic$nextimgnmbr.jpg";
my $prevpic = "pic$previmgnmbr.jpg";

my $next_html = "http://eoinmurphy00.netfirms.com/cgi-bin/albums.cgi?s
+tatus=viewer&album=$album&pic=$nextpic&user=$user";
my $previous_html = "http://eoinmurphy00.netfirms.com/cgi-bin/albums.c
+gi?status=viewer&album=$album&pic=$prevpic&user=$user";


my $viewer_html = qq(
<html>
<head>
<meta http-equiv="Content-Type"
content="text/html; charset=iso-8859-1">
<meta name="GENERATOR" content="Microsoft FrontPage Express 2.0">
<title>Apres Bonne Anse Plage</title>
</head>

<body bgcolor="#000098" link="#FFFFFF" vlink="#FFFFFF"
alink="#FFFFFF">

<p align="center">&nbsp;</p>
<div align="center"><center>

<table border="0" cellpadding="0" cellspacing="0">
    <tr>
        <td colspan="5"><img src="http://eoinmurphy00.netfirms.com/ima
+ges/title.jpg"
        width="780" height="224"><br>
        </td>
    </tr>
    <tr>
        <td colspan="5"><div align="center"><center><table
        border="1" cellpadding="0" cellspacing="0" width="780">
            <tr>
                <td align="center" bordercolor="#FFFFFF"><div
                align="center"><center><table border="0"
                cellpadding="0" cellspacing="0" width="600">
                    <tr>
                        <td colspan="2"><p align="center"><font
                        color="#FFFFFF" size="7"
                        face="ITC Zapf Chancery"><strong><u>$album</u>
+</strong></font></p>
                        </td>
                    </tr>
                    <tr>
                        <td width="300"><p align="center"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><u><a href="$previous
+_html">Previous</a></u></font></p>
                        </td>
                        <td width="300"><p align="center"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><u><a href="$next_htm
+l">Next</a></u></font></p>
                        </td>
                    </tr>
                </table>
                </center></div><hr>
                <p><img
                src="$src"></p><p>&nbsp;</p>
                <div align="center"><center><table border="1"
                cellpadding="0" cellspacing="0" width="775">
                    <tr>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=home&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Home</u></
+strong></font></a></p>
                        </td>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=albums&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Albums</u>
+</strong></font></a></p>
                        </td>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=upload&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Upload</u>
+</strong></font></a></p>
                        </td>
                        <td align="center" valign="bottom"
                        bordercolor="#FFFFFF"
                        bordercolordark="#FFFFFF"
                        bordercolorlight="#FFFFFF"><p
                        align="center"><a
                        href="http://eoinmurphy00.netfirms.com/cgi-bin
+/main.cgi?status=contact&user=$user"><font
                        color="#FFFFFF" size="5"
                        face="ITC Zapf Chancery"><strong><u>Contact
                        </u></strong></font></a></p>
                        </td>
                    </tr>
                </table>
                </center></div></td>
            </tr>
        </table>
        </center></div><p><font color="#FFFFFF" face="Abbess"><img
        src="http://eoinmurphy00.netfirms.com/images/border.jpg" width
+="780" height="51"></font></p>
        </td>
    </tr>
</table>
</center></div>
</body>
</html>
);

return $viewer_html
}
[download]

I you seemed to be able to spot things that I cannot. Any help is greatly appriciated.
Thanks
All the Best, Eoin... _{If everything seems to be going well, you obviously don't know what the hell is going on.}

In reply to Re: Re: link errors by eoin
in thread link errors by eoin

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.