First off, advice on improving your script: start over! ;)

Here is your syntax error, you have a structure like so:

foreach (@stuff) { if ($boolean) { ... } } else { ... }
That is invalid code. At this point, your script is almost (but not necessarily) beyond repair. I suggest that you sit down, design what you want to accomplish, and then use HTML::Template - this module will allow you you to take the HTML out of your Perl script so you can focus on logic. It takes a little time to understand HTML::Template, but it is time well invested -- as is designing. I also recommend you take the time to indent your code properly. If you don't know how to do that, then download Perl Tidy and run your code through it. Without proper indention, you run into problems like you have above. A lot of newbies say "I'll go back and indent it later." This never happens. Indent as you code and avoid mistakes like you have above. Best of luck. :)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

In reply to Re: syntax error by jeffa
in thread syntax error by eoin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.