The code below works and churns out two strings (CSV) from a single input data array. However, its getting too close to being obfuscated especially with the lc(pack_format) in the middle.
Pointers and improvements requested
sub split_up {
my $ary_ref = shift;
my @d = @{ $ary_ref };
my $CUST_FMT = 'A A9 A3 A60 A10 A20 A40 A35 A35 A35 A35 A35 A10 A
+3 A20 A20 A20 A50 A A A A A6 A6';
my $CHILD_FMT = 'A9 A20 A20 A20 A A A A6 A6 A6';
my ($a1, $a2, $a3, $a4, $a5) = ($d[4] =~ /.{35}?/g);
my @cust_data = ('A', $d[0], 'WEB', '', $d[1], $d[2], $d[3], $a1,
+$a2, $a3, $a4, $a5, $d[5], $d[6], $d[7], '', '', $d[8], '', $d
[19], '', '', $d[18], '');
my @child_data = ($d[0], @d[9..17]);
my $cust = join ',', (unpack lc($CUST_FMT), (pack $CUST_FMT, @cu
+st_data));
my $child = join ',', (unpack lc($CHILD_FMT), (pack $CHILD_FMT, @c
+hild_data));
return ($cust, $child);
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.