That's a fine way to export subs if you simply want subs from the current package to be exported to the calling package, and while it may be much faster than the likes of Exporter, speed isn't really an issue when it comes to importing.

While you could get this working under strict, it would mean going through many hoops to avoid symbolic referencing, so this is one of those cases where turning off strictures is a good idea 

## limit the disabling of strict refs to this scope
{
  ## let us do symbolic referencing
  no strict 'refs'

  sub import {
    ## get the caller once
    my $pkg = caller;

    for(qw/ sub1 sub2 /) {
      ## don't over-write existing subs
      *{"$pkg\::$_"} = \&$_
        unless defined &{"$pkg\::$_"};
    }
  }
}

[download]
The only reason I can think for using Exporter apart from laziness, is it can export symbols to a higher calling frame, otherwise I reckon Juerd's Exporter::Tidy is pretty ideal (although it could do with optional exporting, time for a patch methinks ...)1.

HTH

_________
broquaint

1 just realised this doesn't make any sense. move along folks

In reply to Re: fast import? by broquaint
in thread fast import? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.