Your solution might be fast, but it also allows anyone to clobber the value of any variable in the package's namespace. Depending on how you code, this may or may not be a problem, but me thinks it's better to avoid the problem entirely.

Instead, explicitly put all the names of the fields you allow in an array. My arg-parsing routines usually look something like this:

{ my @FIELDS = qw( foo bar baz ); sub set_params { use CGI qw(:standard); map { $_ => param($_) || '' } @FIELDS; } } # Other subroutines here { my %params = set_params(); # Call other subroutines here }

It's much safer, and a change in the fields only means a change in the @FIELDS array. I use a similar form for object constructors:

{ my @FIELDS = qw( foo bar baz ); sub new { my $class = shift; my $in = shift || { }; # Passed in a hashref my %self = map { $_ => $in->{$_} || '' } @FIELDS; bless \%self, $class; } }

----
I wanted to explore how Perl's closures can be manipulated, and ended up creating an object system by accident.
-- Schemer

Note: All code is untested, unless otherwise stated


In reply to Re: More efficient reading of forms in CGI by hardburn
in thread More efficient reading of forms in CGI by bradcathey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.