One thing to keep in mind is that while striving for efficiency is important, it waste time profitably spent elsewhere. If you have a script that runs twice as long as it could, what does it matter if it only runs once a month? I'm not saying that's the case here. It's just something I like to keep in mind.

Oftimes, while I find that I can write a more efficient regex than one I find in a program that I am working on, I ask myself two questions:

  1. Will it be harder to maintain?
  2. How necessary is optimizing the program?
Understanding optimization is important, but it's also important to understand when to optimize.

For example in one script, I had to write the following regex: 

$input =~ /^(?:[^_]|_(?!${value}))+_${value},((?:[A-Z]\d{1,2},?)+).*/;

[download]
Because of the nature of the data, I could have written (untested): 
$input =~ /$value,((?:\w\d{1,2},?)+)/;

[download]
The second regex may not be easy to understand, but it's a heck of a lot easier to understand then the first. If the script didn't require maximum efficiency, I would have chosen the second for maintainability.

Cheers,
Ovid

In reply to (Ovid - when *not* to optimize) Re: File reading efficiency and other surly remarks by Ovid
in thread File reading efficiency and other surly remarks by Hot Pastrami

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.