the following piece of code, is working fine, but I have my doubts about some of the stuff i do in it...

use POSIX;
use File::Copy;
use strict;

my $serverdir="/kode/perlstuff/test/";

# function for copying all files and directories recursivly with new r
+ead only permissions
sub copyrecursivly{
    my $p_source=shift;
    my $p_destination=shift;
    
    if (-d $p_source){
    mkdir $p_destination,"0755";
    opendir(datadir,$p_source);
    foreach my $tempvalue (grep {!/^\./} readdir(datadir)){
        copyrecursivly($p_source . "/" . $tempvalue,$p_destination . "
+/" . $tempvalue);
    }
    closedir(datadir);
    }else{
    copy($p_source, $p_destination);
    }
}

# Check that the BACKUP/ directory is present, otherwise create it
if (!opendir(backupdir,$serverdir . "BACKUP/")){
    mkdir $serverdir . "BACKUP/" , "0755";
    opendir(backupdir,$serverdir . "BACKUP/") or die "could not create
+ backup directory!";
}
closedir(backupdir);

# Open the server directory, and create the backup destination directo
+ry
opendir(datadir,$serverdir) or die "could not open server directory!";
my $destinationdir=$serverdir . "BACKUP/dailyimage_" . POSIX::strftime
+ "%Y-%d-%m", localtime;
mkdir $destinationdir;

# Copy all files from source to destination
foreach my $tempvalue (grep {!/^\.|[BACKUP]/ } readdir (datadir)){
    copyrecursivly($serverdir . $tempvalue,$destinationdir . "/" . $te
+mpvalue);
}
closedir(datadir);

[download]

ok first of all... for my normal variables i use my within my recursive function, which should make them safe... but what about my file handles? The code works fine, but since I read all data from the filehandles before i recurse further, it should work fine even if my filehandle names are within the same scope... but then my closedir statements are not closing all opened directories... which they should! So my question is, are they within in the same scope? and if so, how do i make them local to the function?

Next question... am I giving the right parameters to mkdir inorder to achieve 755 rights on the directory?

Final question... is there anything in this piece of code which i ought to do differently?

thanks Kasper

In reply to bag of questions... by kapper

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.