Your code continues to scare me. What's with the int functions when subscripting already forces an integer? And why do you continue to use $n * rand() when rand($n) does the same thing? And are you sure your randl function always returns a value within the range of the array subscripts? I think it can return negative numbers at first glance, which would then access the ending array elements overly often.

In short, thanks for wanting to contribute, but please get a little more Perl experience under your belt, so we don't have to steer others away from your code. If you want, please preview your post by emailing it to me, and I'll be happy to provide you with suggestions.

-- Randal L. Schwartz, Perl hacker

In reply to RE: RE: RE: Randomly Choose an Element from an Array by merlyn
in thread Randomly Choose an Element from an Array by sinan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.