Why are you assigning to $self->{"property$n"} and then returning $self->{property}?

That is a typo, which I then copied.

Your @_ test also makes little sense to me. If you are trying to write get/set routines, you would want to get on a single routine, set on 2, and think about throwing an error on 3 or more.

Yes. This is another typo. Should have been >=, not >. The error on 3 or more makes sense, but I usually forget those.

Fortunately, I have Attribute::Property, so I can even write working code when I'm as tired as I was when I wrote that node.

If you are going to have a lot of very similar code, then I think that autogenerating can be good.

I've put all my favourite object-property-code in Attribute::Property, together with xmath. It was originally made to allow $foo->bar = 14; syntax, but I use it now mostly because it makes creating classes much easier. (And when I'm tired, apparently this means I make less mistakes. See the other node: I made no mistake in the lines that use : Property :-))

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }