unless (($key =~ /^,|,,|,$/))

Cute, testing for the negative is much more readable here ... but probably something I wouldn't have tried. You need to check for the characters being in the valid class though (and I'd also put brackets around the anchors) so that would make it...

unless (($key =~ /(?:^,)|,,|[^a-zA-Z,]|(?:,$)))

Which isn't quite as nice anymore :(. So I'd probably still use the "obvious" non-negative...

if (($key =~ /^[a-zA-Z]+(?:,[a-zA-Z]+)*$))

Or if I was feeling really special, I might even do...

my $field = qr([a-zA-Z]+); if (($key =~ /^$field(?:,$field)*$))

...which is slightly more readable IMO.

update (broquaint): changed <pre> to <code> tags


In reply to Re: Re: regex: only want [a-zA-Z] and comma chars in a string by nevyn
in thread regex: only want [a-zA-Z] and comma chars in a string by heezy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.