That's all good advice, but I'd make some corrections / improvements to your regexp.

Well, I wouldn't go so far as to call any of that a "correction."

You offer at least one improvement, however. There's certainly no reason to capture as I was. Using [^>]* is arguably better as well, although it wouldn't be likely to make much of a practical difference in this case.

As for your other changes, while I am a firm believer in robust and explicit regular expressions, I also believe strongly in keeping things simple. Given my understanding of the OP's question, I'd guess that both your \Q quoting and the /g modifier are probably unnecessary. (In fact, my decision not to use /g and my decision not to use non-greedy matching went hand in hand.)

My sense of the problem after reading the explanation and the code was that each string had only one such replacement. (Perhaps I should've suggested a last; in there as well.) After reading it again, I can see where that might be an incorrect assumption. I may have given too much weight to the single example he gave.

Still, keeping the regex relatively close to the OP's original attempt might help his understanding, and that, afterall, was my real intent.

++ for your rigor though and I do appreciate the feedback.

-sauoq
"My two cents aren't worth a dime.";

In reply to Re: Re: Re: replacing strings using reg exp by sauoq
in thread replacing strings using reg exp by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.