The obligatory line -- "use strict; use warnings;". You are presenting this as an example of your work. You want them to know that you are aware of the kind of errors that the pragmas address, and you have taken steps to remove them.

Stylistic commentary:

* Re-format everything with an 80 character line. It makes everyone's life miserable if they have to keep scrolling back and forth to read the end the text. In particular, don't be so stingy with the '#' characters. Multiline comments are simply ducky.

* DO you expect the script to "kill your system"? If so, fix the bug. If not, think about *not* including that line. It makes me think more than twice about using your code.

* You might try commenting the regexes you use to identify the comic to be pulled. Either with the 'x' option inline with the regex, or as comment block before each one. This is provides the next person who updates the code a leg up on what to expect from the regex, and it gives you a cross check on whether the regex actually is doing what you just said it does.

* You might want to consider adding a POD stanza to provide external documentation. Give the potential User a paragraph or so description of the Code and What It Does, and they don't have to wade through the code. It's the same principal as a car-seller handing out printed specifications; it keeps the potential buyer from getting down on their knees to look at the under-carriage.

Good luck on the interview.

OGB

In reply to Re: Script Review... by Old_Gray_Bear
in thread Script Review... by draxil42

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.