"doh!!!"...As usual when I post a question on a Saturday night my brain isn't at 100%......I knew what the problem was when I woke up this morning. Its funny how sleep can clarify things. The problem as I see it, is the precedence of "if" and "or" when using that "trailing if" idiom. So when I added the "or warn", the statement

chmod($dirmode, $_) if (-d $_) or warn $!;

if (-d $_) or warn $!;

would always return true, since warn is always there, and everything, both files and directories were made 0755. My solution is (without Bart's correct fixes about octal() ) :

#!/usr/bin/perl -w use strict; use File::Find; my $topdir = shift || '.'; my $filemode = shift || 0644; my $dirmode = shift || 0755; find(\&doit, "$topdir"); sub doit { return if $_ eq "." or $_ eq ".."; if(-f $_){chmod($filemode, $_)or warn $!} if(-d $_){chmod($dirmode, $_) or warn $!} }

In reply to Re: File::Find, chmod and warnings by zentara
in thread File::Find, chmod and warnings by zentara

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.