Other monks have mentioned about error handling when the file to view is not found, so I will not say it again. Just a few comments on your code -

  my $request=$ENV{'QUERY_STRING'};
  $request=~/([-\w_]+\.($ext))/g;
  my $file=$1;

[download]
can be written in one line as follows:
  my ($file) = $ENV{'QUERY_STRING'} =~ /([-\w_]+\.($ext))/g;

[download]
And also the in code -
  foreach(@code){
    $_=~s/</&lt;/g;
    $_=~s/>/&gt;/g;
  }

[download]
You can drop the $_ =~ part as it is not necessary (to save a few keystrokes)
  foreach(@code){
    s/</&lt;/g;
    s/>/&gt;/g;
  }

[download]
If you want to improve your Perl programming skills, you should learn to use CGI and HTML::Template as these powerful modules can make CGI programming really easy.

Suggestion: Why don't you go off and modify your script to use CGI, and then post your new code here as part of a learning experience?

In reply to Re: Not my first program, but the first I'll share... by Roger
in thread Not my first program, but the first I'll share... by pekkhum

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.