Style notes on your new method.

The ref $proto || $proto line is one which people disagree on the utility of. merlyn in particular is known for disliking it. My thoughts are milder, but I still dislike it. If you look in the thread starting here, I explain what it is supposed to do and why it doesn't really succeed.

Also you are defining $self and then returning it. There is no need to do that. Just return the result of bless.

And if you've made both of those changes, then there is no reason not to reduce a trivial new down to: 

sub new {
    bless {}, shift;
}

[download]

In reply to Re: Re: Re: Re: Package Variables in Inheritance by tilly
in thread Package Variables in Inheritance by reyjrar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.