I'm working on untainting some directory path input and I would like a bit of advice on cleaning up directory paths.

I derived the following code from untainting user login information. I added in comments to show what I think is going on. Please correct me if I'm way off base here. $de is just some random variable name I popped in for testing. :p

My goal is to allow people to drill down in a specific directory tree such as Current_Directory/X/Y/Z but to refuse to allow them to use relative paths to leave the directory tree such as Current_Directory/../../Important_File_Name. So I came up with the following.

$de =~ s([^a-zA-Z0-9 _/\.-])()g; #strip everything that's not approved +. $de =~ tr(./)(./)s; #Look for repeats of the . and / and squash them. $de =~ m/(\w+.*)$/; #Strip off leading . and / just in case. $de = $1;
Is there anything important I'm missing here?

Is it fair to stick a link to my site here?

Thanks for you patience.


In reply to Cleaning up directory paths. by SavannahLion

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.