If you feel you need a new approach because of speed concerns, you almost certainly don't want to use Parse::RecDescent. It's nice as far as abstractions go, but it is quite slow in my experience.

But, if you think the code is crufty and you can do better with your advanced knowledge of perl and you have the time/resources to rewrite the code, go for it. It sounds like you've got a handle on a potential problem with the original code anyway (matches variable errors rather than not-so-variable keep lines). If speed really is a concern, you should profile the existing code first. It may be that your current approach to matching error lines is plenty fast and that the bottleneck is really somewhere else.

duff

In reply to Re: To parse or not to parse by duff
in thread To parse or not to parse by set_uk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.