Hi

I am new to Perl and have just written a script that reads text files from a directory and then sends the data on through a socket connection. It's a very simple process but is very cpu intensive so I suspect my loop and file handling is very flawed. Could someone take a little look at this main loop for me and comment. thanks a lot

the process is 'daemonized' first before entering main loop

opendir DH, "/tmp/store" or die "could not open directory: $!";
while (1) {



while($_ = readdir(DH) ) {

    next if $_ eq "." or $_ eq "..";
    my @data = split /_/;
    $mobile = $data[1];
    undef @data;
    chomp $mobile;
    s/^\s+//, s/\s+$//, s/\s\s+/ / for $mobile;
    open FH,"/tmp/sms/$_" or die "could not open: $_  $!";
    undef $/;
    my $data = <FH>;
    chomp $data;
    my @fields = split;
    my $appcode = $fields[0];
    my $message = $data;
    s/^\s+//, s/\s+$//, s/\s\s+/ / for $data;
    close FH;
    sendtolive($mobile,$message); # Sends data through socket connecti
+on
    unlink("/tmp/sms/$_"); # remove file once read
    }

}
closedir DH;

[download]

20031118 Edit by Corion: Added CODE tags, changed title from "cpu intensive"

In reply to network socket send loop is very cpu intensive by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.