Updated: It now includes checking for cycles.

That seems way complicated. I went with: 

*isa = \&UNIVERSAL::isa;

sub flatten
{
    my @stack= reverse @_;
    my %seen;
    my @out;
    while(  @stack  ) {
        my $value= pop(@stack);
        if(  !ref($value)  ||  !isa($value,"ARRAY")  ) {
            push @out, $value;
        } elsif(  ! $seen{0+$value}++  ) {
            push @stack, reverse @$value;
        }
    }
    return @out;
}

sub flatten2
{
    my @out;
    my %seen;
    while(  @_  ) {
        my $value= shift(@_);
        if(  !ref($value)  ||  !isa($value,"ARRAY")  ) {
            push @out, $value;
        } elsif(  ! $seen{0+$value}++  ) {
            unshift @_, @$value;
        }
    }
    return @out;
}

my @list = ( 1, [ 2, 3 ], 4, [ [ 5, 6 ], 7, [ 8 ] ] );
print join " ", flatten( @list, @list );
print $/;
print join " ", flatten2( @list, @list );
print $/;

[download]
which outputs: 
1 2 3 4 5 6 7 8 1 4
1 2 3 4 5 6 7 8 1 4

[download]

                - tye

In reply to Re^3: flattening a list-of-lists (simpler) by tye
in thread flattening a list-of-lists by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.