Late to the party, again, but one thing nobody has commented on is that your if-structure re-tests the same thing multiple times. Instead of:
if (($genome[$i] eq 'a') && ($genome[$i+1] eq 'a')) { ++$tt; } elsif (($genome[$i] eq 'a') && ($genome[$i+1] eq 'g')) { ++$a +g; } elsif (($genome[$i] eq 'a') && ($genome[$i+1] eq 'c')) { ++$a +c; } elsif (($genome[$i] eq 'a') && ($genome[$i+1] eq 't')) { ++$a +t; } elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 'a')) { ++$t +a; } elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 'g')) { ++$t +g; } elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 'c')) { ++$g +a; } elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 't')) { ++$t +t; }
you should have had:
if ($genome[$i] eq 'a') { if ($genome[$i+1] eq 'a') { ++$tt; } elsif ($genome[$i+1] eq 'g') { ++$ag; } elsif ($genome[$i+1] eq 'c') { ++$ac; } elsif ($genome[$i+1] eq 't') { ++$at; } } elsif ($genome[$i] eq 't') { if ($genome[$i+1] eq 'a') { ++$ta; } elsif ($genome[$i+1] eq 'g') { ++$tg; } elsif ($genome[$i+1] eq 'c') { ++$ga; } elsif ($genome[$i+1] eq 't') { ++$tt; }
etc.

Of course, the hash is a better solution for this problem, but I thought that the redundant testing problem should be pointed out.


In reply to Re: how can I speed up this perl?? by Roy Johnson
in thread how can I speed up this perl?? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.