One problem is that you're not doing any error checking on $dbh->prepare or $dbh->do. Probably if you put in some error checking, whatever problem you're having will become more clear.

The other problem is that $dbh->do takes a string to execute, not a statement handle. If you have an already-prepared statement, like the one in $sth, you want to use $sth->execute. 

my $sth = $dbh->prepare("INSERT into 1985_onwards_slim_I (Year_of_deat
+h, Ageyears, Sex, Undcause, OAcode)
     SELECT Col003, Col020, Col023, Col029, Col051 from 1985_onwards_f
+ull_data_set")
  or die "Couldn't prepare query: ".$dbh->errstr;
$sth->execute()
  or die "Couldn't execute query: ".$sth->errstr;

[download]

Update: I've fixed a typo in the above. Thanks to 3dan for the correction.

In reply to Re: DBI Insert by sgifford
in thread DBI Insert by Win

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.