I am working with a directory that contains both data files and marker files. The marker files have the same base name as the data files but a different extension. They are used as markers that identify the data files that are no longer used. As a result, the files exist as pairs unless they are current in which case only the data file is present. An example directory listing would contain:

00000001.did
00000001.mrg
00000002.did
00000002.mrg
00000003.did
[download]

I want to work with all of the current data files so I am using the code below to find the list of data files that does not have a corresponding marker file.

sub unmergedFiles
{
    my $dir = shift;
    my %merged;
    my @files;
    
    # create the hash containing the merged files
    foreach (glob ($dir."/*.mrg"))
    {
        if ( /(\S+)\.mrg/i )
        {
            $merged{lc ($1 . ".did")} = "1";
        }
    }
    
    foreach (glob ($dir."/*.did"))
    {
        unless (exists $merged{lc($_)})
        {
            push @files, $_;
        }
    }
    # return style as per node 311537!
    return wantarray ? @files : \@files;
}
[download]

This code works just fine but I would like the opinion of more learned monks as to how this code can be improved. A couple of things spring to mind:

• There is probably a CPAN module to do this already but I haven't looked as writing the code was educational.
• I am really just comparing the contents of two arrays to find the difference. Have I missed out on a more concise method?
• I am creating a hash by iterating over an array and assigning new hash elements. Is there a better way of doing this?

All comments gratefully received!

inman

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.