Look into the
Memoize function, which can remember the results
of prior queries to speed it up. First, break out the lookup into a separate function:
sub lookup {
die unless wantarray; # call me in list context only
my $item = shift;
return values %{$EMail{$item}} if exists $EMail{$item}; # category n
+ame
for my $cat (keys %EMail) {
return $EMail{$cat}{$item} if exists $EMail{$cat}{$item}; # single
+ name
}
return; # not found
}
sub GetEmailFor {
my @results = map { lookup($_) } @_;
return join ",", @results;
}
This should be equivalent code (and quite faster, I might add {grin}).
Now, let's speed it up further:
use Memoize;
memoize('lookup');
sub I_have_changed_EMail {
unmemoize('lookup');
memoize('lookup');
}
and be sure to call
I_have_changed_EMail any time you change
your dataset (none at all if you "set it and forget it", as you indicate already).
There. Speed without too much work.
-- Randal L. Schwartz, Perl hacker
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.