I haven't looked through the whole program yet, but you appear to do this:

my ($sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst) = loc +altime(); $mon += 1; $year += 1900; my $timestamp = sprintf( "%04d%02d%02d %02d:%02d:%02d", $year, $mon +, $mday, $hour, $min, $sec );

quite a bit. Use strftime() instead.

use POSIX qw(strftime); my $ts = strftime("%Y%m%d %H:%M:%S", localtime);

In reply to Re: Seek Critique of program, format, structure, overall "Perl"ness by duff
in thread Seek Critique of SFTP program, format, structure, overall "Perl"ness by mikedshelton

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.