Just one quick thought:
$data =~ s/\s+/ /g;
$data =~ s/ +//g;
# remove leading and trailing blanks
$data =~ s/^\s+//;
$data =~ s/\s+$//;
What you do here is first to substitute any whitespace characters by blanks, then all blanks by nothing and then you look for blank at the beginning and the end of your data. As your RegEx to validate input is
$data =~ /^([-\@\w. ]+)$/, I would guess that you might have wanted to leave the second RegEx out. If not so, you could just substitute all four of them by
$data =~ s/\s+//g;.
Also, your RegEx for validation could be rewritten using negated charachter classes, for example
if ($data !~ /[^-\@\w. ]/) { ..., but that's just a question of personal preference.
You code looks fine to me, but always keep in mind that untainting data depends on what you do with it afterwards.
Cheers,
CombatSquirrel.
Entropy is the tendency of everything going to hell.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.