If at all possible, its best to avoid either way: make the caller provide an array ref every time. That allows $date to be a blessed object whose underlying type is a hash but which has overloaded @{} array-dereference.

No matter how you code the decision, there is some ambiguity. The caller could be passing an array-based object yet intending that the split be done using the object's overloaded stringify, for instance.

In a sense, if you are checking UNIVERSAL::isa and then treating it as a plain array ref, you are voilating the object's encapsulation. Why should the underlying type matter to you? Conversely, it is often convenient for an object method to be able to pass the object if it were just an array ref.

To sum it all up, you are guessing the caller's intent, and anything that involves a guess should preferably be avoided.


In reply to Re: Is "ref $date eq 'ARRAY'" wrong? by ysth
in thread Is "ref $date eq 'ARRAY'" wrong? by bronto

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.