First of all, your code doesn't compile. Secondly, your indentation is pretty poor. Here's what I think the code should look like: (Not compiled -- just reformatted using perltidy)

if (param()) {
    my $name   = param('name');
    my $update = param('search');

    if ($search eq "Exact") {
        if ($name) {
            if (exists $snailmail{$name})  # Missed closing )
            {
                print "$snailmail{$name}";
            } else {
                print " Name not found in directory ");
            }  # Missed open and closing braces
        } else {
                  print " Please enter a name to search for ";

                  #  Nothing here allows a user to enter a name.
        }  # Missed open and closing bracesA
    } elsif ($search eq " All ") {
              foreach (sort keys %snailmail) {
                  print "$_ : $snailmail{$_} ";
              }
    }  # Missed closing brace
}  # Missed closing brace

[download]

Finally, I'd suggest you do some work running this code through the debugger, trying different values and seeing where it takes you. If you're still stuck after all that, come on back and post again.

--t. alex
Life is short: get busy!

In reply to Re: Possible looping or syntax error by talexb
in thread Possible looping or syntax error by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.