Can someone see why?

When facing code like this, I often find that the problem pops right out when I do a little refactoring. I'd start by breaking out two separate subroutines, along the lines of: 

  if ( param('Submit') ) {
      handleSubmit();
  }
  else {
      emitForm();
  }

[download]
Right away, this breaks the problem down into smaller pieces. Then, I'd rewire logic in handleSubmit to handle the error cases first as "guard clauses". Something like: 
  if ( $name eq "" ) {
      print "<font color=red>Blah blah blah.</font>";
      return;
  }
  if ( $email eq "" ) {
      print "<font color=red>Blah blah blah.</font>";
      return;
  }
  ...
  open(MAIL, "|$sendmail -t") or die "Cannot access mail";
  print MAIL "To: $adminmail\n";
  print MAIL "From: $email\n";
  ...

[download]
At this point, I'd have an "oh shit" moment, and would arrange to turn on taint-checking and add code to validate $email to ensure that someone isn't sneaking in an exploit, but that's really a separate issue.

Try this approach, and see if you can't figure the problem out yourself.

In reply to Re: Form problems by dws
in thread Form problems by sulfericacid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.