Couple of things:

First of all, you use port 8080 for this daemon, which strikes me slightly as odd. Of course you are free to use any port available, but port 8080 is usually used as an alternative for HTTP.

Secondly, I miss authentication/security ;) This daemon -as I see it- allows connections from everywhere and is ok with the idea that the client is giving the filename. I don't know much about the win32 OS (which you seem to use), but imagine this on a *NIX machine and I decide to upload some text file with a filename of "/etc/passwd" and "/etc/shadow". (Ok, true enough, running this daemon as root is stupid to begin with ;) I'm sure there are files on your OS that you'd rather see not updated by the clients. Using authentication at least gives you someone to blame when things go ugly, and of course, please do check the filename input.

Finally, have you considered the already available alternatives, such as ftp, sftp/scp, rsync (does that exist on win32?)? You could even write an upload CGI script, and let your http daemon "handle" the connections.

Just my €0.02

--
b10m

In reply to Re: Client(s) sending file(s) to server using Sockets by b10m
in thread Client(s) sending file(s) to server using Sockets by rupesh

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.