Actually in a sense $bytesread should be doing something though... I should be ensuring that it is undef on each iteration of the loop... I think I now see the light. I should rewrite this as:
{
# read() returns the number of bytes read or undef on error
$bytesread = read($raw_file,$buffer,1024);
# let's exit with an error if read() returned undef
die "error with file read: $!" if !defined($bytesread);
# let's exit with an error if print() did not return true
unless (print O $buffer) die "error with print: $!";
# let's redo the loop if we read > 0 chars on the last read
redo unless !$bytesread
}
And many thanks for one of the very first posts ever from the all-great
merlyn which showed me the merits of a naked do block.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.