In my quest to amend an email conversion script, I've come across the following code to pull out files from a directory:-
while ($file = <$dir\\*.txt>) { #do your stuff }
Whenever I have had to access files from a directory before I've used the approach:-
opendir ( DIR, $dir ) || die "Cannot open directory $dir: $!"; while ( defined( $file = readdir(DIR) ) ) { next if $file =~ /^\.\.?$/; if ( $file =~/txt$/ ) { #do your stuff } } closedir DIR;
Benchmarking shows only a small difference in performance, with opendir the slightly better of the two.

All I want to know is - is there any other difference between the two approaches that I should take into account?

Or am I fussing over nothing? :-}

elbow

Update - I take back the slight difference part - benchmarking shows a huge difference between the two pieces of code on a directory with a lot of *.txt files in!

In reply to opendir or not? by elbow

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.