I have alot of conditions in a function and would like to know if it can be shortened and made more efficient with the help of Perl experts. The script works on my NT but want to see if it can be shortened and look any better?
use strict; use warnings; my $macf = 0; my $syman = 0; #intialize all the other variables etc... #start of mainfunction here sub mainfunction(); { if(($macf == 0) && ($syman == 0)) { if(($mac eq $oldMac) && ($sym eq $oldSym)) { print "no changes\n"; } elsif(($mac ne $oldMac) && ($sym ne $oldSym)) { print "section C UPDATE\n"; } elsif($mac ne $oldMac) { print "section B UPDATE\n"; } elsif($sym ne $oldSym) { print "SEction E updated\n"; } } elsif(($macf == 0) && ($syman != 0)) { if($mac ne $oldMac) { print "MacSEction updated\n"; } else { print "no changes to mac\n"; } } elsif(($macf != 0) && ($syman == 0)) { if($sym ne $oldSym) { print "syman update\n"; } else { print "no changes to syman\n"; } } } #end of main function #start of condition checks to call correct function if(($syman == 0) && ($macf == 0)) { myfunc1(); myfunc2(); mainfunction(); } elsif(($syman == 0) && ($macf != 0)) { myfunc1(); mainfunction(); } elsif(($macf == 0) && ($syman != 0)) { myfunc2(); mainfunction(); }

In reply to Shorten function conditions by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.