I would be inclined to approach code like that using a "table-driven" approach.

Naturally, this being Perl, we can use idiomatic techniques with hashes and regexes rather than a by-the-book C-ish implementation.

An (untested) stab at your problem might look like this:

# Keys in %rules are ! $macf, ! $syman, eq $oldMac, eq $oldSym my %rules = ( '1111' => 'no changes', '1100' => 'section C UPDATE', '1101' => 'section B UPDATE', '1110' => 'SEction E updated', '100.' => 'MacSEction updated', '101.' => 'no changes to mac', '01.0' => 'syman update', '01.1' => 'no changes to syman', ); sub mainfunction { my $state = join('', map { $_ ? 1 : 0 } ($macf == 0), ($syman == 0), ($mac eq $oldMac), ($sym eq $oldSym) ); if ( my $rule = ( grep { $state =~ $_ } keys %rules )[0] ) { my $result = $rules->{$rule}; print $result . "\n"; } }

In reply to Re: Shorten function conditions by simonm
in thread Shorten function conditions by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.