Update: Never mind, there's enough responses here already

As mentioned before, you need to change that loop. Here is my offering:

sub MysqlIN { # Why is that '@_' in there, are you passing in an # array of three values? # That's what I'll assume, so I'll change this line #my %dateparts = ( YEAR => '', MONTH => '', DAY => '', @_, ); # To this: my %dateparts = ( YEAR=>shift, MONTH=>shift, DAY=>shift ); my $element; while (my ($name, $value) = each %dateparts) { # Number validation added die "Invalid value for $name" unless $value and $value=~/^\d+$/; # You don't need to exit, you already died! # exit; } my $mysqldate = join ("-", @dateparts{qw(YEAR MONTH DAY)}); return $mysqldate; }

In reply to RE: Validating hash values by runrig
in thread Validating hash values by rodry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.