Refactoring is an ongoing practice. You should be constantly doing it every time you code. Whenever you end up with three routines that do basically the same thing they should get replaced. (Perl offers a wide reange of ways to do this intelligently, from code generation, to closures, to complex argument handling schemes.) You shouldn't have any global variables. Either encapsulate that data into an object, or pass it as required as parameters.

Without seeing your code in depth, and the problem space it operates in we cant suggest anything solid. Its a skill you learn, where to put data and routines, what modularizes nicely, what doesnt. Expect to get it wrong a few times. Its not uncommon for me to rewrite from scratch the same body of code two or three or even four times before I'm happy with the design.


---
demerphq

    First they ignore you, then they laugh at you, then they fight you, then you win.
    -- Gandhi

In reply to Re: reworking a large program by demerphq
in thread reworking a large program by gri6507

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.