It looks like you are not passing arguments to your subroutine, and using @array1 as a global variable too.

You will have to pass the arg and file as parameters, and get the array as the return value.So the call will go from:

  # you use strict do you?
  my $arg1= "foo";
  my $file1="bar";
  my @array1;
  file_processing();
  foreach (@array1) { process( $_); }

[download]

to

  my $arg1= "foo";
  my $file1="bar";
  my @array1=  file_processing( $arg1, $file1);
  foreach (@array1) { process( $_); }

[download]

The subroutine should look like this: 

sub file_processing {
  my( $arg, $file)= @_;                        # added
  my @array;                                   # added
  $script = "/export/home/ssesar/Perl/another_script.pl -e";
  $open = "$script $arg $file";                # changed
  open(FILE, "$open |") or die "can't do it\n";# changed
        while (<FILE>) {                       # changed
            chomp;
   next if /^\#/;
          next if /None/;
          next if /Unkno/;
          next if /unkno/;
          next if /NONE/;
            @_ = split ( /\n/, $_);
            @array = @_;
        }
  close FILE;
  return @array;                           # added
  }

[download]

In reply to Re: Subroutine question by mirod
in thread Subroutine question by Limo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.