The sort keys not doing a numeric sort is definitely going to cause some unusual effects for you. The other very wrong thing I see is that second delete $upload{count}. I think that will cause you to delete an extra record when you are trying to delete the last one. Fix it by skipping the second loop (everything that involves $count) and just deleting $upload{++$num} after the first loop instead.

In terms of style points, you should be saying = -1, not = "-1"; there's no point in setting a string and then turning around and incrementing it; just use a number.

I assume you are using the split-up parts $filename2, etc. in code that you've trimmed away; if these are really unused, get rid of the split and join lines and just use $upload{$_} where you have $joined.

And I'd say $upload{$num} = $joined if $num != $_; no point in updating your database if nothing changed.

In reply to Re: rebuilding a hash (more) by ysth
in thread rebuilding a hash (more) by coldfingertips

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.