tilly's addressed your main point, but I thought I should point out two things about
get_top_sources:
- You're never subtracting from $total when you add stuff to your return value, meaning that the "other" slice is forever too big
- Including the "other" slice, you actually produce $max_wedges+1 wedges
Here's what I might do, but I'm a bit odd. After you calculate
@sorted...:
my @sorted = sort {
$events{$b}{'count'} <=> $events{$a}{'count'}
} keys %events;
if (@sorted > $max_wedges)
{
map { $events{'other'}{'count'} += $_ }
@sorted[$max_wedges..$#sorted];
@sorted[$max_wedges..$#sorted] = ('other');
}
return [map { {$_ => $events{$_}{'count'}}; } @sorted];
Note that $total is now never used, so there's no longer any reason to be calculating it above.
This uses map heavily, which is sometimes a bit odd to get used to, but I find it leads me to write stuff that I can look at later and easily read. YMMV.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.