I don't understand why you are trying to read your query string from a file like that. Just use a string: 
my @field = qw(
   Title Email City State Country URL
   Date Description rid dt_create publish
);

my $insert_sth = $dbh->prepare(
   'INSERT INTO ads_2004 ('
   . join(', ', map "'$_'", @fields)
   . ') VALUES (?,?,?,?,?,?,?,?,NULL, NOW(), 0)'
);

[download]
And use placeholders (those question marks). Now, if your form fields are named JUST LIKE your database table columns, then you can do some tricks to save typing and prevent typos: 
use CGI qw(:standard);

my %field;
for (@field) {
   my $param = param($_);
   die unless $param;     # do validation on $param here ...
   $field{$_} = $param;
}

# or validate specific pieces outside the loop:
die unless $field{rid} =~ /^\d+$/;
die unless is_valid_email($field{Email});

$insert_sth->execute(values %field);

[download]
By the way, your SQL snippet has ELEVEN fields and only TEN values. This is the kind of typo i was talking about. ;)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

In reply to Re: Right answer (wrong question...) by jeffa
in thread Right answer (wrong question...) by bobafifi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.