Your hashes are scoped within the first function there, and are not accessible outside of it. Either move them so they are global (like with 'use vars'), or scope the sort function within the caller (or at least within the same block as the variables themselves). 
sub do_msalist {    
   my (%country, %state, %msaname, @msakeys);

   sub by_americentric {    
      $country{$b} cmp $country{$a}  or
      $state{$a}   cmp $state{$b}    or    
      $msaname{$a} cmp $msaname{$b}  or    
      $a <=> $b
   }
 
   foreach (sort by_americentric @msakeys) {
      ...
   }
}

[download]
When dealing with Perl scoping issues, try to think less about how Perl might "see" the variables and think about where the variables are physically placed in the source code.

In reply to Re: Named Sort Subs with Strict? by Fastolfe
in thread Named Sort Subs with Strict? by spudzeppelin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.