The trouble is that you're localizing the variables in one block, then trying to use them in another. Since the variables exist in do_msalist(), they don't exist in by_americentric().

You need to have the variables accessible by by_americentric(). There are a few ways to do this. One way is to put both of the subroutines inside an enclosing block, like this: 

{
    my (%country, %state, %msaname);

sub do_msalist {

    my @msakeys = @_;

    foreach(sort by_americentric @msakeys) { 
        #...
    }

}

sub by_americentric {
    $country{$b} cmp $country{$a}
    or
        $state{$a} cmp $state{$b}
    or
        $msaname{$a} cmp $msaname{$b}
    or
        $a <=> $b;
}

}

[download]

Or, you can define the associative arrays as package variables with 'use vars'. Or you can just put by_americentric in as a blockin do_msalist, and call it that way: 

sub do_msalist {

    my @msakeys = @_;

    foreach(sort {
    $country{$b} cmp $country{$a}
    or
        $state{$a} cmp $state{$b}
    or
        $msaname{$a} cmp $msaname{$b}
    or
        $a <=> $b;
} @msakeys) { 
        #...
    }

}

[download]
That'll work if you only call by_americentric right there. But it's harder to read.

stephen

In reply to Re: Named Sort Subs with Strict? by stephen
in thread Named Sort Subs with Strict? by spudzeppelin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.