Unrolling the loop is faster, but it is also more prone to
mistakes. My version is the simplest that is legible yet
does the specified job. My personal preference would be to
wait to unroll it until after I find that I truly need to
do so.
I rarely do. Unlike lookaheads with wildcards in them, the
underlying implementation of mine is worst case off by a
constant factor from the best possible. (The worst case,
of course, being things like "foobababababafoo".)
Furthermore my hope is that someday (not today of course)
Perl's RE engine won't need such mechanical optimizations
since it will do them on the fly.
And a question for you. While you unrolled it correctly,
how many people here do you think would have got it right
on their first or second try? (Or ever - most in my bet
would have stopped before getting it right.) If your goal
is correct code (which mine is) then be *very* careful
before going through optimizations like this.
UPDATE
You did not, in fact, unroll it correctly. The string I gave above of a "worst case" in fact should match and does not match your regex!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.