FWIW, I would write this code: 
  $shift->caption($args->{'caption'});
  $shift->starts($args->{'starts'});
  $shift->ends($args->{'ends'});
  $shift->monday($args->{'monday'});
  $shift->tuesday($args->{'tuesday'});
  $shift->wednesday($args->{'wednesday'});
  $shift->thursday($args->{'thursday'});
  $shift->friday($args->{'friday'});
  $shift->saturday($args->{'saturday'});
  $shift->sunday($args->{'sunday'});
  $shift->holiday($args->{'holiday'});

[download]
as: 
$shift->$_( $args->{$_} ) foreach qw(
 caption
 starts
 ends
 monday
 tuesday
 wednesday
 thursday
 friday
 saturday
 sunday
 holiday
);

[download]
You're specifying things twice (name of method and name of field in hash), which is always bad from a maintenance point of view.

Also, I find the use of $shift confusing: usually a variable called $self is a more common idiom.

Liz

In reply to Re: Class::DBI misbehaviour by liz
in thread Class::DBI misbehaviour by TVSET

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.