The problem is that you haven't actually read what I've suggested. In the pseudocode, that you've written (cut'n'pasted), you parrot back to me the idea of using two separate loops and of pushing the filename onto an array but you've kept your single loop structure.

Of course it's not going to work.

The specific problem of what is wrong is (because you're doing all of this in a single loop) when you chdir into your backup directory. Because you never chdir out again, you never find the second file and so your program halts there.

You should be getting an error about that, but you haven't included that in your message. :(

Anyway, the code that follows is probably what you're looking for. Compare it with the pseudocode I suggested to you. See how we have 2 loops and a check between them and all the things I suggested.

Notice too, that I've changed your backup directory name. If you don't like my suggestion then feel free to change it back again.

#!/usr/bin/perl -wT

use strict;
use File::Copy;

...

chdir "/var/files" or die "/var/files: $!\n";
-f "/var/files/info" or die "No info NO TRANSFER !\n";

my @ftp_locations = ($directory_1, $directory_2);

# open the file safely or complain it wouldn't open
open(FILE, "<", "info") or die "Failed to open info file: $!";

# Read all the lines in from info
my @files;
for(my $i = 1; $i <= @ftp_locations; $i++) {
        $_ = <FILE>;

        s/\W*$//;            # remove trailing whitespace
        next if (!$_);       # skip empty lines

              # check that we get our match.  If not,
              # complain and move on.  Want to see two
              # filenames.
       unless(/^([\w.-]+) \s+ ([\w.-]+)$/x) {
                print STDERR "$_ is not a valid line";
                next;
        }

        # rename the files as per rename in file
        my ($old, $new) = ($1, $2);
        unless( -e $old ) {
                print STDERR "$old does not exist!\n";
                next;
        }
        rename $old, $new;

        push @files, $new;
}

# check that we have the number of files that we expect
unless(@files == @ftp_locations) {
      die "Not enough specified ftp_locations for ".
          "given number of files!";
}

# create backup subfolder
my @dt = localtime;
my $subfoldername = ($dt[5]+1900) . "-" . ($dt[4]+1) .
                    "-$dt[3]:$dt[2]:$dt[1]_$$";

mkdir "/var/files/out/$subfolder_name" or die "$subfolder_name: $!";

# FTP each file across, die on errors
foreach my $new (@files) {
       my $destination = shift @ftp_locations;

        # ftp transfer
        my $ftp = Net::FTP->new ($server, Timeout => 9000, Debug => 3)
+;

        $ftp or die "$server: cannot connect: $@";
        # If you don't use ~/.netrc
        $ftp->login ($user,$password)
            or die "$_: cannot logon: " . $ftp->message;

        # change remote directory for the first file
        $ftp->cwd($destination);

        # Send file to ftp server
        $ftp->put($new) or
        die "$server: cannot put $new: " . $ftp->message;
        #Quit FTP When finished
        $ftp->quit;

        # move file to backup directory
        unless(move("$new", "/var/files/out/$subfolder_name")) {
               print STDERR "Oops!  Couldn't move the file: $!";
        }
        # Sleep for 20 minutes before processing next file.
        sleep (20 * 60)
}

# If we get to this point then we've renamed, ftped and moved the file
+s
# so send an email saying so...
[download]

Good luck with this.

jarich

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.