I have a question about a working piece of code. I have used a bunch of foreach and while statements to get the result I need but it just looks ugly and I'm sure there is a better way of doing it.
Any tips on efficiency and/or style would be great.
#!/usr/bin/perl -w use strict; my(@tcpstatus,@tcpalive,$date,$line); my($ftp,$www,$ssh,$irc); $date = `date +"%l:%M:%S"`; $ftp = 0; $www = 0; $ssh = 0; $irc = 0; @tcpalive = (); ############################ # get current tcp status # ############################ @tcpstatus = `cat /proc/net/tcp`; ############################ # grab only the ones that # # are marked "Active" (01) # # and put them into new # # array # ############################ foreach (@tcpstatus) { while (/\b01\s/) { push(@tcpalive,$_); last; } } ############################ # ugly. I know there has # # got to be a better way # # to get this done. Step # # through new array and # # add how many times each # # service is found # ############################ foreach (@tcpalive) { while (/:0050\s/) { $www++; last; } } foreach (@tcpalive) { while (/:0016\s/) { $ssh++; last; } } foreach (@tcpalive) { while (/:1A0B\s/) { $irc++; last; } } foreach (@tcpalive) { while (/:0015\s/) { $ftp++; last; } } ############################ # print this out to a file # # used for server side # # includes # ############################ open (FILE, "+>/var/www/web/main.txt"); print FILE "There are $www web, $ftp ftp, $ssh ssh, and $irc irc conne +ctions to this server as of $date\n"; close FILE;


Thanks,
djw

In reply to efficiency & style by djw

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.