There are already a few other good replies, but none of the other monks have mentioned that fact that your code does not actually have a loop anywhere. It's easy to discern where you want the loop, but I think it should at least be pointed out that you don't have one.

Here's a version using a while loop:

while (1) {
    chomp(my $choice = <STDIN>);

    if    ($choice == 1) { &hash1; }
    elsif ($choice == 2) { &hash2; }
    elsif ($choice == 3) { &hash3; }
    else {
        print "ERROR: Please type in either 1, 2 or 3.\n";
        redo;
    }

    last;
}

[download]

Update: fixed code to actually do what was asked.

You might want to add some checking to make sure $choice looks like a number before trying to use numeric comparisons against it. Scalar::Util's looks_like_number subroutine might be just the ticket.

In reply to Re: simple loop by revdiablo
in thread simple loop by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.