my $max=0;

That's the classic max (or min) implementation error. What if all numbers are negative? 

$ perl -e'@a=qw(-1 -2 -3 -4 -5); 
          $max=0; 
          printf "Answer allegedly is %d\n",map { $max=($max < $_ ?  $
+_ : $max )} @a;'
Answer allegedly is 0

$ perl -e'@a=qw(-1 -2 -3 -4 -5); 
          $max=$a[0]; # Or shift @a, if you can be destructive
          printf "Answer allegedly is %d\n",map { $max=($max < $_ ?  $
+_ : $max )} @a;'
Answer is -1

[download]

Mike

In reply to Re: Re: largest number inside array/hash by RMGir
in thread largest number inside array/hash by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.