I should point out that if your script really starts with a line like this: 
##################################

[download]
followed by the "shebang" line, then it will not run as an executable in any sort of unix(-like) shell. The shebang line must be the very first line.

Apart from that, my initial snap reaction is that it would be better (more appealing to the novice, without being more cryptic) if there were less repetition: the two rather ugly sets of print statements that "talk to the user", each one followed by very similar-looking foreach loops, are a sure sign that you'd be better off with a subroutine that you call twice with different parameters each time. When newbies catch on to subroutines -- which is not that hard to do -- it strikes them as the coolest thing and they love it immediately. You shouldn't deny them that pleasure.

In reply to Re: Code review for magazine article? by graff
in thread Code review for magazine article? by McMahon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.