As others have said, the problem is that "readdir()" returns file names, and the "-f" test needs the path of the directory being read to be attached to each file name, in order to find each file.
One other point: you could do what you want in a single pass, using "grep":
my $path = "C:/some/path";
opendir( ORIG, $path ) or die "opendir failed on $path: $!";
my @filesInDir = grep { -f "$path/$_" } readdir( ORIG );
closedir ORIG;
How easy is that? If you really want to list all the files and non-files to STDOUT while you're reading the directory (which you'll probably get tired of quickly), here's what I would put in place of that single grep line:
while ( my $file = readdir( ORIG ))
{
my $verb = "isn't";
if ( -f "$path/$file" ) {
push @filesInDir, "$path/$file";
$verb = "is";
}
print "$path/$file $verb a file\n";
}
Personally, I like the shorter version better.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.