I agree with tedrek++. The code you show looks fine for syntax.

A few suggestions, however. Your line 135, the first shown, is true unless @results is empty. The usual way to write that is 

if (@results) {
    #...
}

[download]
That works because @results is in scalar context there, giving the number of elements. This decision is not strictly necessary, since the for loop will iterate zero times for an empty @results.

The evident duplication of code in your long run of decisions suggests condensing that section into a loop. A hash for the data with the printed terms "Title".. as keys seems inviting, but suffers from not having a canonical order. Let's just impose that order by defining an array of those terms, 

my @columns = qw/ Title Author Year Journal
                 # ...
                  /;
for my $record (@results) {
    my $index = 0;
    for (split /\|/, $record) {
        printf "%s: %s$/", $columns[$index], $_ if $_;
        $index++;
    }
}

[download]
That condensation separates data from logic, making the whole easier to maintain. It's not the last word, but a step in the right direction.

Have you looked at any of the CSV modules?

After Compline,
Zaxo

In reply to Re: Execution/Compilation Error by Zaxo
in thread Execution/Compilation Error by qball83

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.